Fix ft transfer call message check
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-near/aurora-eth-connector into fix/ft_transfer_call-message-check
birchmd
suggested changes
Jan 20, 2023
aleksuss
reviewed
Jan 20, 2023
aleksuss
reviewed
Jan 23, 2023
aleksuss
reviewed
Jan 23, 2023
…or into fix/ft_transfer_call-message-check
birchmd
approved these changes
Jan 23, 2023
aleksuss
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It fixes bugs related to
ft_transfer_callsender_idcheck for validation messages.Currently, when checking
sender_id == receiver_id, we do not validate is it Aurora contract or not.Solution
Introduce functions:
set_engine_contractget_engine_contractsin
ft_transfer_callchange message verification condition to:Tests
Extended tests for
ft_transfer_callmessage verification.Breaking changes
No.
Gas cost
Not changed.